Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better XIM interaction by filtering modifiers #2000

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

amosbird
Copy link
Contributor

@amosbird amosbird commented Jul 9, 2024

After diagnosing both the server and client sides of xcb-imdkit, specifically rofi and fcitx5, it has been determined that modifiers are causing the slowdown. This is a follow-up to PR #1999.

A new dependency, xcb-keysyms, has been added to properly recognize modifier keys.

I only performed some basic tests based on my daily workflow, and it worked smoothly. Let's see if this fix can stand the test of time.

@DaveDavenport DaveDavenport merged commit 8eb8ff3 into davatorium:next Jul 9, 2024
8 checks passed
@xsy420
Copy link

xsy420 commented Jul 30, 2024

I have tried this pull and #1999
before these two commits, fcitx5 can show and change input method by using

meson setup --reconfigure -Dimdkit=true --prefix=~/.local/ build
ninja -C build

but since #1999, these two commands can't build a rofi that support fcitx5 showing
I have also tried building command in archlinux-rofi
I have xcb-imdkit and xcb-keysyms installed
what am I missing? and what's your building command to build a rofi that makes fcitx5 work perfectly?

@DaveDavenport
Copy link
Collaborator

Do you have any errors it reports? 'it does not build' gives me very little to go on.

For me latest git (that includes these patches) builds fine.

@xsy420
Copy link

xsy420 commented Jul 30, 2024

building process goes fine but after I run rofi -show drun and press my fcitx5 input method changing key-binding fcitx5 doesn't show. before these two commits, it can.
meson.log
ninja.log

@DaveDavenport
Copy link
Collaborator

aah, I thought it did not build with imdkit enabled. I know to little about this to help, @amosbird do you know?

@amosbird
Copy link
Contributor Author

@xsy420 What key binding do you use to toggle the input method?

@xsy420
Copy link

xsy420 commented Jul 30, 2024

when I downgrade xcb-imdkit to 1.0.2
meson.log
left shift key to toggle

@xsy420
Copy link

xsy420 commented Jul 30, 2024

so it is key-binding conflict?

@amosbird
Copy link
Contributor Author

Modifier-alone key bindings won't work after this PR. However, there should be a way to improve this by allowing such events to pass through. I will look into this further.

@xsy420
Copy link

xsy420 commented Jul 31, 2024

maybe try to read [HotKey/TriggerKeys] value in $XDG_CONFIG_DIR/fcitx5/config?

@amosbird amosbird mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants